Fix Pandoc version check in configure #22474
Conversation
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
After trying a few things, I decided upon this solution, which uses grep to isolate the |
|
@bors: r+ b720412a673e2d2afdd574841475d32f157fb593 |
|
@alexcrichton Do you think that using |
|
@bors: r- |
|
I think it's ok. Better than the existing breakage anyway. |
|
Hmm, is it safe to use Edit: I've changed |
|
@brson I was thinking about |
iKevinY
changed the title
Using an extended regex fixes pattern matching on BSD sed.
|
@bors: r+ 4349 |
Executing `configure` seems to create the following error due to how the script [parses Pandoc's version](https://github.com/rust-lang/rust/blob/master/configure#L705): ```text ./configure: line 705: [: pandoc: integer expression expected ./configure: line 705: [: 1.12.4.2: integer expression expected ``` This issue seems to stem from a discrepancy between BSD and GNU versions of sed. This patch changes the sed command to use an extended regex, which works with both flavours of sed.
|
💔 Test failed - auto-linux-32-opt |
|
@bors: retry |
|
⌛ Testing commit 4349fa4 with merge aba1498... |
Executing `configure` seems to create the following error due to how the script [parses Pandoc's version](https://github.com/rust-lang/rust/blob/master/configure#L705): ```text ./configure: line 705: [: pandoc: integer expression expected ./configure: line 705: [: 1.12.4.2: integer expression expected ``` This issue seems to stem from a discrepancy between BSD and GNU versions of sed. This patch changes the sed command to use an extended regex, which works with both flavours of sed.
|
⛄ The build was interrupted to prioritize another pull request. |
|
⌛ Testing commit 4349fa4 with merge 0fa295c... |
|
⛄ The build was interrupted to prioritize another pull request. |
|
⌛ Testing commit 4349fa4 with merge a514272... |
|
⛄ The build was interrupted to prioritize another pull request. |
|
⌛ Testing commit 4349fa4 with merge 6193438... |
|
⛄ The build was interrupted to prioritize another pull request. |
Executing `configure` seems to create the following error due to how the script [parses Pandoc's version](https://github.com/rust-lang/rust/blob/master/configure#L705): ```text ./configure: line 705: [: pandoc: integer expression expected ./configure: line 705: [: 1.12.4.2: integer expression expected ``` This issue seems to stem from a discrepancy between BSD and GNU versions of sed. This patch changes the sed command to use an extended regex, which works with both flavours of sed.
Executing `configure` seems to create the following error due to how the script [parses Pandoc's version](https://github.com/rust-lang/rust/blob/master/configure#L705): ```text ./configure: line 705: [: pandoc: integer expression expected ./configure: line 705: [: 1.12.4.2: integer expression expected ``` This issue seems to stem from a discrepancy between BSD and GNU versions of sed. This patch changes the sed command to use an extended regex, which works with both flavours of sed.
|
⛄ The build was interrupted to prioritize another pull request. |
Executing `configure` seems to create the following error due to how the script [parses Pandoc's version](https://github.com/rust-lang/rust/blob/master/configure#L705): ```text ./configure: line 705: [: pandoc: integer expression expected ./configure: line 705: [: 1.12.4.2: integer expression expected ``` This issue seems to stem from a discrepancy between BSD and GNU versions of sed. This patch changes the sed command to use an extended regex, which works with both flavours of sed.
Executing
configureseems to create the following error due to how the script parses Pandoc's version:This issue seems to stem from a discrepancy between BSD and GNU versions of sed. This patch changes the sed command to use an extended regex, which works with both flavours of sed.