Skip to content

Reject syntax like use std::io::; #21820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Reject syntax like use std::io::; #21820

wants to merge 1 commit into from

Conversation

Potpourri
Copy link
Contributor

syntax like use std::io::; should be rejected, see issue #21629

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@alexcrichton
Copy link
Member

It looks like the syntax use foo:: as bar; is still accepted, could that be explicitly rejected as well?

@Potpourri Potpourri closed this Feb 1, 2015
@Potpourri Potpourri deleted the import-syntax branch February 1, 2015 20:13
@Potpourri
Copy link
Contributor Author

Sorry for deleted branch, i was wrong.
In case use foo:: as bar;, as parsed as part of module path, and not keyword.
I fixed it and created new pr.

@alexcrichton
Copy link
Member

Did you mean to re-open the PR? (it's still closed)

I think you can re-open by recreating the branch, but otherwise feel free to open a new PR

@Potpourri
Copy link
Contributor Author

i cant re-open this pr, i do not know what the problem

@alexcrichton
Copy link
Member

Ah well, feel free to open a new one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants