syntax: Don't put quotes around filenames in codemap #21617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ends up propagating all the way out to the output of dep-info which then makes Cargo think that files are not existent (it thinks the files have quotes in their name) when they in fact do.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -146,7 +146,7 @@ pub fn expand_include_str(cx: &mut ExtCtxt, sp: Span, tts: &[ast::TokenTree]) | |||
| Ok(src) => { | |||
| // Add this input file to the code map to make it available as | |||
| // dependency information | |||
| let filename = format!("{:?}", file.display()); | |||
| let filename = format!("{}", file.display()); | |||
|
I guess I don't have a particular problem with this commit, except that I expect things like filenames to be quoted or otherwise "set apart" in an error message. It seems surprising to me that cargo is scraping this information from the error -- what if there is a space in the name or something? |
|
Giving r+ in any case. |
|
@nikomatsakis my impression was that cargo is not scraping the info from an error, but rather from the output of |
bors
added a commit
that referenced
this pull request
Jan 26, 2015
This ends up propagating all the way out to the output of dep-info which then makes Cargo think that files are not existent (it thinks the files have quotes in their name) when they in fact do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ends up propagating all the way out to the output of dep-info which then
makes Cargo think that files are not existent (it thinks the files have quotes
in their name) when they in fact do.