Associated types support for deriving::TraitDef #21614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -51,7 +51,8 @@ pub fn expand_deriving_bound<F>(cx: &mut ExtCtxt, | |||
| path: Path::new(vec!("std", "marker", name)), | |||
| additional_bounds: Vec::new(), | |||
| generics: LifetimeBounds::empty(), | |||
| methods: vec!() | |||
| methods: Vec::new(), | |||
| associated_types: Vec::new(), | |||
There was a problem hiding this comment.
either way it is now more consistent (used to be both Vec::new() and vec!() here)
|
I fetched this code and verified that the updated Rust works for my case in gfx-rs. 👍 |
bors
added a commit
that referenced
this pull request
Jan 26, 2015
Fixes #21497 I don't know if this can be tested with built-in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21497
I don't know if this can be tested with built-in tests.