Avoid suggesting traits multiple times. #21421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is clearly useless, the user doesn't need to know that they could implement/import `foo::bar::Baz` 4 times. Fixes rust-lang#21405.
|
r? @Aatch (rust_highfive has picked a reviewer for you, use r? to override) |
|
(I haven't actually tracked down why this was happening at all, but it seems like deduplication is eminently sensible either way.) |
|
@huonw oh, yes, sometimes duplicates show up in these lists I think. |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 21, 2015
This is clearly useless, the user doesn't need to know that they could implement/import `foo::bar::Baz` 4 times. Fixes rust-lang#21405.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is clearly useless, the user doesn't need to know that they could
implement/import
foo::bar::Baz4 times.Fixes #21405.