Skip to content

rustc_trans: Fix type projection debuginfo #20960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2015

Conversation

erickt
Copy link
Contributor

@erickt erickt commented Jan 11, 2015

Closes #20797

@rust-highfive
Copy link
Contributor

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@erickt erickt force-pushed the fix-associated-types-debuginfo branch from 2f2de85 to f7745a9 Compare January 12, 2015 05:39
@erickt
Copy link
Contributor Author

erickt commented Jan 12, 2015

@sfackler: should be fixed now.

@michaelwoerister: you should probably check this out too since I'm new to this area of the code.

@michaelwoerister
Copy link
Member

Looks good, thanks Erick!
I'm fine with this being merged to get rid of the ICE. But I'm not sure it's entirely correct to do it that way. I'll think about it make another PR if necessary.

@kinghajj
Copy link

I'd like to note that while this does fix erickt's example from #20797, my original one still causes an ICE when compiling with this branch merged into the master.

bors added a commit that referenced this pull request Jan 13, 2015
@bors bors merged commit f7745a9 into rust-lang:master Jan 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Associated types: ICE "get_unique_type_id_of_type() - unexpected type"
7 participants