Implement unsafe trait and unsafe impl from the OIBIT RFC
#19703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try!(self.head("")); | ||
| try!(self.print_unsafety(unsafety)); | ||
| try!(self.word_nbsp(visibility_qualified(item.vis, | ||
| "trait").as_slice())); |
There was a problem hiding this comment.
Shouldn't the unsafe go in the middle? This looks like it'll print unsafe pub trait instead of pub unsafe trait.
There was a problem hiding this comment.
good point, have to modify the test (as you also pointed out)
|
Could you also add a |
|
r=me modulo a few nits |
nikomatsakis
force-pushed
the
unsafe-trait
branch
3 times, most recently
from
1148399 to
c822b7c
Compare
|
Needs a rebase |
nikomatsakis
force-pushed
the
unsafe-trait
branch
from
c822b7c to
5e477eb
Compare
|
@nikomatsakis This needs a rebase. |
…d integrating into rustdoc etc.
nikomatsakis
force-pushed
the
unsafe-trait
branch
from
5e477eb to
7855893
Compare
bors
added a commit
that referenced
this pull request
Dec 14, 2014
Implement `unsafe trait` and `unsafe impl` from the OIBIT RFC Reviewed-by: acrichto
bors
added a commit
that referenced
this pull request
Dec 14, 2014
This PR allows declaring traits and impls as `unsafe`. An `unsafe` trait requires an `unsafe` impl. An `unsafe` impl does not permit unsafe code within its interior (unless that code is contained within an unsafe block or unsafe fn, as normal). The commits are standalone. r? @alexcrichton cc #13231
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows declaring traits and impls as
unsafe. Anunsafetrait requires anunsafeimpl. Anunsafeimpl does not permit unsafe code within its interior (unless that code is contained within an unsafe block or unsafe fn, as normal). The commits are standalone.r? @alexcrichton
cc #13231