Don't call drop in tcpstream docs #18818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,18 +34,20 @@ use sys::tcp::TcpAcceptor as TcpAcceptorImp; | |||
| /// A structure which represents a TCP stream between a local socket and a | |||
| /// remote socket. | |||
| /// | |||
| /// The socket will be closed when the reference is dropped. | |||
steveklabnik
force-pushed
the
tcp_doc
branch
from
8b70122 to
54fa2dc
Compare
|
Updated. |
steveklabnik
force-pushed
the
tcp_doc
branch
from
54fa2dc to
9e21137
Compare
This suggests that you must call it, which is normally not what you want to do.
steveklabnik
force-pushed
the
tcp_doc
branch
from
9e21137 to
534fd3a
Compare
bors
added a commit
that referenced
this pull request
Nov 24, 2014
This suggests that you must call it, which is normally not what you want to do. See here: http://www.reddit.com/r/rust/comments/2lpw9k/rust_irc_example_looking_for_feedback/clxnxxc?context=4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This suggests that you must call it, which is normally not what you want to do.
See here: http://www.reddit.com/r/rust/comments/2lpw9k/rust_irc_example_looking_for_feedback/clxnxxc?context=4