Fix an ICE with unsized structs and optimised enums #18591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis was sad: |
| @@ -291,7 +292,7 @@ struct Case { | |||
| #[deriving(Eq, PartialEq, Show)] | |||
| pub enum PointerField { | |||
| ThinPointer(uint), | |||
| FatPointer(uint, uint) | |||
| FatPointer(uint) | |||
There was a problem hiding this comment.
This is a reasonable cleanup, but slightly confusing in that it uses slice_elt_base everywhere and silently depends on it being equal to trt_field_box. I would suggest merging the two constants into something like dst_fat_base or similar.
EDIT: I just noticed you added a comment about this which I hadn't read yet. I'll leave it up to you whether to bother fixing this now or later.
There was a problem hiding this comment.
Yeah, I deliberately left it as a follow up, because I know we make the same assumption all over the place, so fixing isn't super-urgent.
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #18353
r?