Skip to content

Doc: Updates a little the make tips message #18399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gamazeps
Copy link
Contributor

The link to the more detailed tour of rustc, is not a link to the repo
so I don't know if it's ok, but it's the closest to the idea of a build
suite I could find.

Another solution might be to complete the link in the wiki, but I'm not familiar enough with the build suite to do that :/

Closes #17950

The link to the more detailed tour of rustc, is not a link to the repo
so I don't know if it's ok, but it's the closest to the idea of a build
suite I could find.

Closes rust-lang#17950
@steveklabnik
Copy link
Member

I'm concerned about linking to someone's blog over something we control.

@gamazeps
Copy link
Contributor Author

Another solution is to give a link to https://github.com/rust-lang/rust/wiki/Note-rustc-hacking-guide, which is the closest thing we have to an explanation of the build system (the lack of this might be the real issue).

@MatejLach
Copy link
Contributor

It maybe worth contacting @thomaslee to see whether the post can/cannot be converted to markdown and committed to the repo if that's really the best we have on the build system right now.

@gamazeps
Copy link
Contributor Author

Well if @thomaslee is ok with it, I can even try to convert this to markdown.
I can't find any licence file so I won't start untill he says he is ok with it ;)

@thomaslee
Copy link
Contributor

Go for it. Some sort of attribution would be nice, but I'm not precious -- the contents of the post are yours to do as you will, Mozillians. :)

@thomaslee
Copy link
Contributor

Oh and I use Octopress so I may have the markdown handy, will check tonight.

@gamazeps
Copy link
Contributor Author

Awesome !
Great article by the way, thanks a lot for being one of (if not the) only one to have taken time to talk about rustc build suite :)

@thomaslee
Copy link
Contributor

Alrighty, here's the raw markdown: https://gist.githubusercontent.com/thomaslee/fb946b22c5de64bf64a6/raw/e678086df65fd5946c2eb3ffd3079c25f50561cf/gistfile1.md

Rendering is a little quirky in places because of github's markdown variant playing games: https://gist.github.com/thomaslee/fb946b22c5de64bf64a6

@gamazeps if you want to polish this up for a PR or whatever, it's all yours -- otherwise I can get around to it over the next few weeks.

@thomaslee
Copy link
Contributor

Oh and thanks for the kind words. Glad it was helpful. :)

@gamazeps
Copy link
Contributor Author

I think trashing this PR and putting your markdown file (with attribution) in the wiki would be the best solution.
Would that work for everyone (@steveklabnik && @MatejLach && @thomaslee ) ?

@MatejLach
Copy link
Contributor

@gamazeps As @thomaslee seems to be on board, I think it's up to @steveklabnik to have the final word on this, but why would you trash this PR?
I think just updating this PR with a link to the relevant the wiki page, (once it's live), would work fine.

@gamazeps
Copy link
Contributor Author

There already is a link in the original code, to the Notes-build-system wiki page (which is currently empty), filling this page with the content provided by @thomaslee seems to be the best thing to do to me (no need to change code, so no PR).

Otherwise we could link to a page called Notes-rustc-tour (in reference to the original article).

I'm assuming no PR is needed to change the wiki, is that correct ?

@bstrie
Copy link
Contributor

bstrie commented Nov 20, 2014

I don't particularly like the wiki, but I think for now it's the best place we have for something like this. I agree that we shouldn't embed it into the Rust repo itself.

@alexcrichton
Copy link
Member

Closing due to inactivity, but feel free to reopen with comments addressed!

@gamazeps gamazeps deleted the issue17950 branch May 7, 2017 14:52
lnicola pushed a commit to lnicola/rust that referenced this pull request Oct 29, 2024
…qkmv

Fix diagnostic enable config being ignored
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make tips outdated?
6 participants