Skip to content

Guide: Fix inconsistency in 'Marcos' section #17843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2014

Conversation

coffeejunk
Copy link
Contributor

The old version switched in between examples from the value 5i to "Hello" and back.

Additionally, the code generated by rustc print.rs --pretty=expanded is not as verbose anymore.

The old version switched in between examples from the value `5i` to `"Hello"`
and back. Additionally, the code generated by `rustc print.rs
--pretty=expanded` is not as verbose anymore.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

@steveklabnik
Copy link
Member

Thank you!

@coffeejunk
Copy link
Contributor Author

The failed test suite seems unrelated to my changes – is there anything I should/can do about this?

@tbu-
Copy link
Contributor

tbu- commented Oct 8, 2014

@coffeejunk I guess you can ping @steveklabnik (which I just did).

bors added a commit that referenced this pull request Oct 8, 2014
The old version switched in between examples from the value `5i` to `"Hello"` and back.

Additionally, the code generated by `rustc print.rs --pretty=expanded` is not as verbose anymore.
@bors bors closed this Oct 8, 2014
@bors bors merged commit e656aff into rust-lang:master Oct 8, 2014
lnicola pushed a commit to lnicola/rust that referenced this pull request Aug 13, 2024
internal: Performance optimizations

- Use `Command::arg` directly
- Avoid the overhead of the `select!` macro when possible
- Use `select_biased!`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants