Guide: Fix inconsistency in 'Marcos' section #17843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old version switched in between examples from the value `5i` to `"Hello"` and back. Additionally, the code generated by `rustc print.rs --pretty=expanded` is not as verbose anymore.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. |
|
Thank you! |
|
The failed test suite seems unrelated to my changes – is there anything I should/can do about this? |
|
@coffeejunk I guess you can ping @steveklabnik (which I just did). |
bors
added a commit
that referenced
this pull request
Oct 8, 2014
The old version switched in between examples from the value `5i` to `"Hello"` and back. Additionally, the code generated by `rustc print.rs --pretty=expanded` is not as verbose anymore.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Aug 13, 2024
internal: Performance optimizations - Use `Command::arg` directly - Avoid the overhead of the `select!` macro when possible - Use `select_biased!`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old version switched in between examples from the value
5ito"Hello"and back.Additionally, the code generated by
rustc print.rs --pretty=expandedis not as verbose anymore.