Pop the expansion context after expanding a method macro #17319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I vaguely wonder if this would be better with 'check notes' comment directive that makes the compiletest driver fully check any notes (i.e. error if any notes occur on lines without a |
added 2 commits
September 17, 2014 11:18
We were leaving these on the stack, causing spurious backtraces. I've confirmed that this test fails without the fix.
kmcallister
force-pushed
the
method-macro-bt
branch
from
1ff9a45 to
5b42f79
Compare
|
Rebased. |
|
Does this solve #17299? |
bors
added a commit
that referenced
this pull request
Sep 20, 2014
We were leaving these on the stack, causing spurious backtraces.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jun 2, 2024
minor: Missing word typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were leaving these on the stack, causing spurious backtraces.