guide: use _sample configurations..._ rather than _here_ as link text #17242
Conversation
| @@ -185,8 +185,7 @@ Next up is this line: | |||
| This line does all of the work in our little program. There are a number of | |||
| details that are important here. The first is that it's indented with four | |||
| spaces, not tabs. Please configure your editor of choice to insert four spaces | |||
| with the tab key. We provide some sample configurations for various editors | |||
| [here](https://github.com/rust-lang/rust/tree/master/src/etc). | |||
| with the tab key. We provide some [sample configurations for various editors](https://github.com/rust-lang/rust/tree/master/src/etc). | |||
There was a problem hiding this comment.
Can you wrap this like the rest of it, please? Markdown doesn't mind if the [ and ] are on different lines.
There was a problem hiding this comment.
Should I make a 2nd commit or replace this one?
I'm new to this PR game.
There was a problem hiding this comment.
Generally while discussion is ongoing, we prefer that you only add more commits so we can quickly see what has changed. However once you believe everything is good to go, we want the commits rebased into a minimal form (often, a single commit, unless the PR is large) to keep the history neat.
In this case, since the PR is small, and this is likely to be the only issue with it, it's safe to just rebase right away.
There was a problem hiding this comment.
It depends per project. We prefer replace. Just git commit --amend and force push, and it will update the PR
Sent from my iPhone
On Sep 13, 2014, at 15:30, Dan Connolly [email protected] wrote:
In src/doc/guide.md:
@@ -185,8 +185,7 @@ Next up is this line:
This line does all of the work in our little program. There are a number of
details that are important here. The first is that it's indented with four
spaces, not tabs. Please configure your editor of choice to insert four spaces
-with the tab key. We provide some sample configurations for various editors
-here.
+with the tab key. We provide some sample configurations for various editors.
Should I make a 2nd commit or replace this one?I'm new to this PR game.
�
Reply to this email directly or view it on GitHub.
There was a problem hiding this comment.
I used the github web interface to make this PR; I haven't made a real clone of rust in a while. I hope to get around to this eventually, but it may be a while.
There was a problem hiding this comment.
No worries then! I did it for you over in #17278. Thanks so much for the patch!
Change 'Length' to 'Len' This is a fix for rust-lang#17242
No description provided.