Correct internal BitvSet 0-padding, fixes #16542 #16559
Conversation
|
Clever fix! I like the use of |
|
:embarassed: Fixing Eq doesn't change the behaviour of cmp, which is still inherited. Will patch asap. |
|
Sorry about that :stillembarassed: This is a simpler, more robust solution. |
|
One thing I notice here is that As mentioned on IRC, |
| b.mask_words(0).chain(iter::Repeat::new(0u).enumerate().take(0).skip(0))) | ||
| } else { | ||
| (a.mask_words(0).chain(iter::Repeat::new(0u).enumerate().take(0).skip(0)), | ||
| b.mask_words(0).chain(iter::Repeat::new(0u).enumerate().take(a_len).skip(b_len))) |
There was a problem hiding this comment.
Can .take(n).skip(m) be replaced with .take(n - m)? It'd be a little clearer what's going on.
Edit: Never mind, I missed the .enumerate().
|
Regarding the actual code, it looks correct to me. |
These were the only differing-size-based errors I noticed. Might be more.
…nicola Set documentation field in SCIP from doc comment Previously, the documentation field was the same as the text shown to users when they hover over that symbol. The documentation should really just be the doc comment, and as of rust-lang#16179 the signature is already stored in the signatureDocumentation field.
These were the only differing-size-based errors I noticed. Might be more.