Assign more diagnostic codes #15754
Merged
Assign more diagnostic codes #15754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -52,6 +56,10 @@ macro_rules! span_err( | |||
|
|
|||
| #[macro_export] | |||
| macro_rules! span_warn( | |||
There was a problem hiding this comment.
These macros may actually be best written as this:
macro_rules! span_foo(
($session:expr, $span:expr, $code:ident, $($message:tt)*) => ({
__diagnostic_used!($code);
$session.span_warn_with_code($span, format!($($message)*), stringify!($code))
})
)That way you'll handle things like foo=bar as well and you won't need duplicate cases for arguments and no arguments.
bors
added a commit
that referenced
this pull request
Jul 19, 2014
ghost
deleted the
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 27, 2023
…ocal_too, r=Veykril fix: Dedup duplicate crates with differing origins in CrateGraph construction Partially fixes rust-lang#15656 . Until now the condition for deduplication in crate graphs were the strict equality of two crates. One problem that arises from this is that in certain conditions when we see the same crate having different `CrateOrigin`s the first occurrence would be kept. This approach however results in some unwanted results such as making renaming forbidden as this has been recently only made available for local crates. The given example in rust-lang#15656 can still not be resolved with this PR as that involves taking inconsistencies between dependencies into consideration. This will be addressed in a future PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.