libsyntax: no inheritance with tuple/unit structs #15117
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Struct inheritance, unstable as it is, only really makes sense for "record-like" structs and previously produced bad code when used with unit-like structs or tuple structs. So this commit stops parsing super-structs for unit-like structs and tuple structs, and rejects virtual unit-like structs and tuple structs. [breaking-change]
|
cc @nick29581 |
|
I think this should be enforced in typeck, not in the parser. typeck::collect::convert_struct() should be the right place to look. |
|
I initially started adding it there but ended up fairly uncertain whether that was the right place. I was eyeing I'll move the checks over if that's where they ought to be. |
|
Closing due to inactivity, but feel free to reopen with a rebase! |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 18, 2024
…r=Veykril feat: ignored and disabled macro expansion Supersedes rust-lang#15117, I was having some conflicts after a rebase and since I didn't remember much of it I started clean instead. The end result is pretty much the same as the linked PR, but instead of proc macro lookups, I marked the expanders that explicitly cannot be expanded and we shouldn't even attempt to do so. ## Unresolved questions - [ ] I introduced a `DISABLED_ID` next to `DUMMY_ID` in `hir-expand`'s `ProcMacroExpander`, that is effectively exactly the same thing with slightly different semantics, dummy macros are not (yet) expanded probably due to errors, while not expanding disabled macros is part of the usual flow. I'm not sure if it's the right way to handle this, I also thought of just adding a flag instead of replacing the macro ID, so that the disabled macro can still be expanded for any reason if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stops parsing inheritance with tuple structs and unit-like structs to fix #15096.