install: Correct libdir for Windows installs. #15087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iliekturtles Thanks for fixing this, and sorry for the delay reviewing. This looks great to me, but as you say, the lack of the check for |
|
@brson I'll do that, though it may take me a day or two to get to. |
|
@iliekturtles Thank you! |
Platform-detection code from `configure` copied over to `install.sh` in order to special case the lib dir being `bin` on Windows instead of `lib`. Short-term fix for rust-lang#13810.
|
|
bors
added a commit
that referenced
this pull request
Jul 3, 2014
…r=brson Short-term fix per @brson's comment: #13810 (comment). Tested on Win7 x64 and Linux. One possible issue is that `install.sh` doesn't have a `need_cmd` definition like `configure` does. Should this be ported over as well? Platform-detection code from `configure` copied over to `install.sh` in order to special case the lib dir being `bin` on Windows instead of `lib`. Short-term fix for #13810.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 17, 2023
internal: use consistent style for error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short-term fix per @brson's comment: #13810 (comment). Tested on Win7 x64 and Linux.
One possible issue is that
install.shdoesn't have aneed_cmddefinition likeconfiguredoes. Should this be ported over as well?Platform-detection code from
configurecopied over toinstall.shinorder to special case the lib dir being
binon Windows instead oflib.Short-term fix for #13810.