Fix rustdoc's formatting of lifetimes #14906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -91,7 +91,9 @@ impl fmt::Show for clean::Generics { | |||
|
|
|||
| impl fmt::Show for clean::Lifetime { | |||
| fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { | |||
| try!(f.write("'".as_bytes())); | |||
| if self.get_ref() == "static" { | |||
There was a problem hiding this comment.
Hm, I thought static lifetimes should be stored as a literal string 'static (i.e. with the '). This possibly indicates a deeper bug.
There was a problem hiding this comment.
Maybe the deeper bug you are alluding to is here: https://github.com/P1start/rust/blob/rustdoc-lifetimes/src/librustdoc/clean/mod.rs#L620
There was a problem hiding this comment.
Nice catch! That does look like the problem.
There was a problem hiding this comment.
(of course, the link I just posted may not be a bug at all, but rather just a different choice of representation invariant that leads to the use of "static" above rather than "'static". I assume rustdoc would not have the same hygiene issues that rustc has.)
rustdoc was previously formatting lifetimes with two apostrophes, presumably as a result of rust-lang#14797.
bors
added a commit
that referenced
this pull request
Jun 16, 2014
rustdoc was previously formatting lifetimes with two apostrophes, presumably as a result of #14797.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
…-disable-explorer, r=Veykril fix: add a toggle to disable the dependency explorer For common uses of non-Cargo build systems with rust-analyzer, the dependency view isn't particularly helpful because there isn't a Cargo.toml present for dependencies or the dependencies are part of the current workspace. Speaking from the perspective of a user of `rust-project.json`, I'd prefer to have this feature disabled until I can add a field to `Crate` that defines the location of a build file (e.g., a `BUCK`) file, which would allow for removing the "search for a Cargo.toml in parent directories of a crate root" behavior that exists in a few places (I've opened [an issue](rust-lang/cargo#12187) on Cargo to request this data from `cargo-metadata`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustdoc was previously formatting lifetimes with two apostrophes, presumably as a result of #14797.