Move trait impls for primitives near trait definition #14464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| ) | ||
|
|
||
| #[cfg(not(test))] shr_impl!(uint) |
There was a problem hiding this comment.
The #[cfg(not(test))] annotations may be better placed on the impl itself (inside the macro)
|
I think I do like how this has turned out, thank you for tackling this! |
|
Thanks for comments, I forgot how awesome Rust's macros are! |
| )*) | ||
| ) | ||
|
|
||
| totaleq_impl!(() bool char uint u8 u16 u32 u64 int i8 i16 i32 i64 f32 f64) |
There was a problem hiding this comment.
I believe that we specifically don't implement TotalEq for f32 and f64, the rest are fine though.
|
Of course, I'm just really good at making stupid mistakes in code. |
bors
added a commit
that referenced
this pull request
May 28, 2014
This is an attempt of fixing #12925. This PR moves almost all trait implementations for primitive types ((), bool, char, i*, u*, f*) near trait definitions. Only Float trait implementations weren't moved because they heavily rely on constants defined in f32.rs and f64.rs. Some trait implementations had cfg(not(test)) attribute. I suspect it's because of issue 2912. Still, someone who knows the problem better should probably check this code. Closes #12925
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
lower adjusts in simple index except the last one fix rust-lang#14463
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt of fixing #12925.
This PR moves almost all trait implementations for primitive types ((), bool, char, i_, u_, f*) near trait definitions. Only Float trait implementations weren't moved because they heavily rely on constants defined in f32.rs and f64.rs.
Some trait implementations had cfg(not(test)) attribute. I suspect it's because of issue 2912.
Still, someone who knows the problem better should probably check this code.
Closes #12925