rustdoc: Make some attributes methods private. #142739
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followup to https://www.github.com/rust-lang/rust/pull/140863 Only `Item::attributes_and_repr` should be used, the rest are implementation details that can be hidden from the rest of rustdoc.
rustbot
added
S-waiting-on-review
fmease
reviewed
Jun 19, 2025
| @@ -764,7 +764,7 @@ impl Item { | |||
| Some(tcx.visibility(def_id)) | |||
| } | |||
|
|
|||
| pub(crate) fn attributes_without_repr(&self, tcx: TyCtxt<'_>, is_json: bool) -> Vec<String> { | |||
| fn attributes_without_repr(&self, tcx: TyCtxt<'_>, is_json: bool) -> Vec<String> { | |||
There was a problem hiding this comment.
This one is actually only called by attributes_with_repr IIRC. In #116882 I actually inline this method and rename atrributes_with_repr to attributes because repr is an attribute and since the relevant bit of Guillaume's ADT / type alias unification PR is the fact that we now have a standalone fn repr_attributes
|
Given that #116882 also makes these changes, I think I'll close this in favor of that, so we don't get needless merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #140863
Only
Item::attributes_and_reprshould be used, the rest are implementation details that can be hidden from the rest of rustdoc.r? @GuillaumeGomez