remove duplicate crash test #142674
remove duplicate crash test #142674
Conversation
rustbot
added
S-waiting-on-review
|
Makes sense. @bors r+ |
bors
added
S-waiting-on-bors
…r=bjorn3 remove duplicate crash test I noticed near duplication between "library/alloctests/tests/testing/crash_test.rs" and "library/alloctests/testing/crash_test.rs" and wanted to try and remove that. The only difference is the path used to import `Debug`, but it seems not to matter. Perhaps my change is still wrong? r? `@bjorn3`
…r=bjorn3 remove duplicate crash test I noticed near duplication between "library/alloctests/tests/testing/crash_test.rs" and "library/alloctests/testing/crash_test.rs" and wanted to try and remove that. The only difference is the path used to import `Debug`, but it seems not to matter. Perhaps my change is still wrong? r? ```@bjorn3```
Rollup of 11 pull requests Successful merges: - #140774 (Affirm `-Cforce-frame-pointers=off` does not override) - #141610 (Stabilize `feature(generic_arg_infer)`) - #142383 (CodeGen: rework Aggregate implemention for rvalue_creates_operand cases) - #142591 (Add spawn APIs for BootstrapCommand to support deferred command execution) - #142619 (apply clippy::or_fun_call) - #142624 (Actually take `--build` into account in bootstrap) - #142627 (Add `StepMetadata` to describe steps) - #142660 (remove joboet from review rotation) - #142666 (Skip tidy triagebot linkcheck if `triagebot.toml` doesn't exist) - #142672 (Clarify bootstrap tools description) - #142674 (remove duplicate crash test) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #142674 - hkBst:remove-duplicate-crashtest, r=bjorn3 remove duplicate crash test I noticed near duplication between "library/alloctests/tests/testing/crash_test.rs" and "library/alloctests/testing/crash_test.rs" and wanted to try and remove that. The only difference is the path used to import `Debug`, but it seems not to matter. Perhaps my change is still wrong? r? ``@bjorn3``
Rollup of 6 pull requests Successful merges: - #135656 (Add `-Z hint-mostly-unused` to tell rustc that most of a crate will go unused) - #138237 (Get rid of `EscapeDebugInner`.) - #141614 (lint direct use of rustc_type_ir ) - #142123 (Implement initial support for timing sections (`--json=timings`)) - #142377 (Try unremapping compiler sources) - #142674 (remove duplicate crash test) r? `@ghost` `@rustbot` modify labels: rollup
Rollup of 11 pull requests Successful merges: - rust-lang/rust#140774 (Affirm `-Cforce-frame-pointers=off` does not override) - rust-lang/rust#141610 (Stabilize `feature(generic_arg_infer)`) - rust-lang/rust#142383 (CodeGen: rework Aggregate implemention for rvalue_creates_operand cases) - rust-lang/rust#142591 (Add spawn APIs for BootstrapCommand to support deferred command execution) - rust-lang/rust#142619 (apply clippy::or_fun_call) - rust-lang/rust#142624 (Actually take `--build` into account in bootstrap) - rust-lang/rust#142627 (Add `StepMetadata` to describe steps) - rust-lang/rust#142660 (remove joboet from review rotation) - rust-lang/rust#142666 (Skip tidy triagebot linkcheck if `triagebot.toml` doesn't exist) - rust-lang/rust#142672 (Clarify bootstrap tools description) - rust-lang/rust#142674 (remove duplicate crash test) r? `@ghost` `@rustbot` modify labels: rollup
Rollup of 6 pull requests Successful merges: - rust-lang/rust#135656 (Add `-Z hint-mostly-unused` to tell rustc that most of a crate will go unused) - rust-lang/rust#138237 (Get rid of `EscapeDebugInner`.) - rust-lang/rust#141614 (lint direct use of rustc_type_ir ) - rust-lang/rust#142123 (Implement initial support for timing sections (`--json=timings`)) - rust-lang/rust#142377 (Try unremapping compiler sources) - rust-lang/rust#142674 (remove duplicate crash test) r? `@ghost` `@rustbot` modify labels: rollup
|
@bjorn3 I suppose an alternative would be to make this into its own crate. It's maybe a bit much for this little code, but perhaps also a bit cleaner. I may be accumulating a bit more code that is used both in unit tests and integration tests for alloc, so I'd love to hear your thoughts on this. |
|
It should be possible to include this code from FWIW my goal is to get rid of all unit tests in the standard library crates and replace them with integration tests as has already been done for libcore and liballoc. This way the way the standard library is tested can become much less fragile. Currently it depends the standard library copy from the sysroot having the exact same crate hash as the one included through a cargo dependency, so any divergence (cargo profile, enabled features, RUSTFLAGS, ...) between building the sysroot and building the test crates will cause a compilation failure due to duplicate lang items. |
That does sound like a good option.
Interesting! It sounds like this could open up new avenues, though I can't quite comprehend the implications. |
I noticed near duplication between "library/alloctests/tests/testing/crash_test.rs" and "library/alloctests/testing/crash_test.rs" and wanted to try and remove that. The only difference is the path used to import
Debug, but it seems not to matter. Perhaps my change is still wrong?r? @bjorn3