Skip to content

enable TLS for windows-gnu #141794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

mati865
Copy link
Member

@mati865 mati865 commented May 30, 2025

It didn't work a few years ago but seems to be working now.

try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
try-job: dist-x86_64-mingw
try-job: dist-i686-mingw

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 30, 2025
@mati865
Copy link
Member Author

mati865 commented May 30, 2025

@bors try

@bors
Copy link
Collaborator

bors commented May 30, 2025

⌛ Trying commit 2223668 with merge ecb3eb3...

bors added a commit that referenced this pull request May 30, 2025
enable TLS for windows-gnu

It didn't work a few years ago but seems to be working now.

try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
try-job: dist-x86_64-mingw
try-job: dist-i686-mingw
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-mingw-2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Updating files:  98% (52416/53485)
Updating files:  99% (52951/53485)
Updating files: 100% (53485/53485)
Updating files: 100% (53485/53485), done.
branch 'try' set up to track 'origin/try'.
Switched to a new branch 'try'
##[endgroup]
[command]"C:\Program Files\Git\bin\git.exe" log -1 --format=%H
ecb3eb32d7591da0bb0de36faa37f743a2a2e12a
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
---
file:.git/config remote.origin.url=https://github.com/rust-lang/rust
file:.git/config remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
file:.git/config gc.auto=0
file:.git/config http.https://github.com/.extraheader=AUTHORIZATION: basic ***
file:.git/config branch.try.remote=origin
file:.git/config branch.try.merge=refs/heads/try
file:.git/config submodule.library/backtrace.active=true
file:.git/config submodule.library/backtrace.url=https://github.com/rust-lang/backtrace-rs.git
file:.git/config submodule.library/stdarch.active=true
file:.git/config submodule.library/stdarch.url=https://github.com/rust-lang/stdarch.git
file:.git/config submodule.src/doc/book.active=true
---
    ptr::write_unaligned_drop

test result: FAILED. 1891 passed; 1 failed; 6 ignored; 0 measured; 0 filtered out; finished in 5.23s

error: test failed, to rerun pass `-p coretests --test coretests`
"D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage0\\bin\\cargo.exe" "test" "--manifest-path" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage1-tools\\cg_clif\\build\\sysroot_tests\\Cargo.toml" "--target-dir" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage1-tools\\cg_clif\\build\\sysroot_tests_target" "--locked" "--target" "x86_64-pc-windows-gnu" "-p" "coretests" "-p" "alloctests" "--tests" "--" "-q" exited with status ExitStatus(ExitStatus(101))
error: process didn't exit successfully: `D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage1-codegen\x86_64-pc-windows-gnu\release\y.exe test --download-dir D:\a\rust\rust\build\cg_clif_download --out-dir D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage1-tools\cg_clif --no-unstable-features --use-backend cranelift --sysroot llvm --skip-test testsuite.extended_sysroot` (exit code: 1)
Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:54:48
make: *** [Makefile:126: ci-mingw-bootstrap] Error 1
  local time: Fri May 30 22:26:47 CUT 2025
  network time: Fri, 30 May 2025 22:26:47 GMT
##[error]Process completed with exit code 2.

@bors
Copy link
Collaborator

bors commented May 30, 2025

💔 Test failed - checks-actions

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 30, 2025
@mati865
Copy link
Member Author

mati865 commented May 30, 2025

It looks like it needs the latest GCC or Binutils to work.
Passes locally with toolchains provided by MSYS2 but fails on CI with older toolchain:

  ---- ptr::write_unaligned_drop stdout ----
  ---- ptr::write_unaligned_drop stderr ----
  note: got unexpected return code -1073741819
  
  failures:
      ptr::write_unaligned_drop

@mati865 mati865 closed this May 30, 2025
@mati865 mati865 deleted the windows-gnu-tls branch May 30, 2025 23:19
@mati865 mati865 restored the windows-gnu-tls branch June 1, 2025 15:31
@mati865 mati865 deleted the windows-gnu-tls branch June 1, 2025 15:33
@mati865
Copy link
Member Author

mati865 commented Jun 1, 2025

FWIW previously I had did only stage1 which is not enough to test spec changes. Reran the test locally with stage2 and it still works. So indeed, enabling this is just the matter of waiting an unspecified amount of time before minimal versions for GCC+Binutils+mingw-w64 can be set high enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants