Skip to content

Rollup of 9 pull requests #140781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
May 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
abc57dc
Remove estebank from automated review assignment
jieyouxu May 2, 2025
df13f7c
Require T: TypeFoldable in Binder<T> visit
compiler-errors Apr 23, 2025
1f774d7
Only prefer param-env candidates if they remain non-global after norm
compiler-errors May 6, 2025
8a21d1b
Review
compiler-errors May 7, 2025
a910329
Use MaybeCause::or to allow constraints from overflows if they are co…
compiler-errors May 6, 2025
b27d630
Point out region bound mismatches in check_region_bounds_on_impl_item
compiler-errors Apr 30, 2025
fc0ef54
opaque_type_storage to InferCtxtLike
lcnr May 4, 2025
e7979ea
detect additional uses of opaques after writeback
lcnr May 4, 2025
f03d246
Better error message for late/early lifetime param mismatch
compiler-errors May 1, 2025
aeb70c7
rustdoc-json: Remove newlines from attributes
aDotInTheVoid May 7, 2025
38e3fa6
style: Never break within a nullary function call `func()` or a unit …
joshtriplett May 7, 2025
5913e55
Add `DefPathData::OpaqueLifetime` to avoid conflicts for remapped opa…
Zoxc May 7, 2025
1799f5f
triagebot: Better message for changes to `tests/rustdoc-json`
aDotInTheVoid May 7, 2025
8a3ab85
Rollup merge of #140260 - compiler-errors:only-global-post-norm, r=lcnr
matthiaskrgr May 8, 2025
a810f8a
Rollup merge of #140523 - compiler-errors:late-early-mismatch, r=jack…
matthiaskrgr May 8, 2025
1521f2c
Rollup merge of #140579 - jieyouxu:temp-remove, r=wesleywiser
matthiaskrgr May 8, 2025
aace488
Rollup merge of #140641 - lcnr:opaque-type-storage-entries, r=compile…
matthiaskrgr May 8, 2025
74b79ae
Rollup merge of #140711 - compiler-errors:combine-maybes, r=lcnr
matthiaskrgr May 8, 2025
cd235bd
Rollup merge of #140762 - aDotInTheVoid:popnl, r=GuillaumeGomez
matthiaskrgr May 8, 2025
b330d04
Rollup merge of #140764 - joshtriplett:style-nullary-functions, r=tra…
matthiaskrgr May 8, 2025
34feb21
Rollup merge of #140769 - Zoxc:fix-140731, r=oli-obk
matthiaskrgr May 8, 2025
526923a
Rollup merge of #140773 - aDotInTheVoid:rdj-triagdfsadgs, r=dtolnay
matthiaskrgr May 8, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions compiler/rustc_borrowck/src/type_check/opaque_types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -266,10 +266,6 @@ impl<'tcx, OP> TypeVisitor<TyCtxt<'tcx>> for ConstrainOpaqueTypeRegionVisitor<'t
where
OP: FnMut(ty::Region<'tcx>),
{
fn visit_binder<T: TypeVisitable<TyCtxt<'tcx>>>(&mut self, t: &ty::Binder<'tcx, T>) {
t.super_visit_with(self);
}

fn visit_region(&mut self, r: ty::Region<'tcx>) {
match r.kind() {
// ignore bound regions, keep visiting
Expand Down
15 changes: 8 additions & 7 deletions compiler/rustc_hir/src/definitions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,8 @@ pub enum DefPathData {
/// An existential `impl Trait` type node.
/// Argument position `impl Trait` have a `TypeNs` with their pretty-printed name.
OpaqueTy,
/// Used for remapped captured lifetimes in an existential `impl Trait` type node.
OpaqueLifetime(Symbol),
/// An anonymous associated type from an RPITIT. The symbol refers to the name of the method
/// that defined the type.
AnonAssocTy(Symbol),
Expand Down Expand Up @@ -445,7 +447,8 @@ impl DefPathData {
pub fn get_opt_name(&self) -> Option<Symbol> {
use self::DefPathData::*;
match *self {
TypeNs(name) | ValueNs(name) | MacroNs(name) | LifetimeNs(name) => Some(name),
TypeNs(name) | ValueNs(name) | MacroNs(name) | LifetimeNs(name)
| OpaqueLifetime(name) => Some(name),

Impl
| ForeignMod
Expand All @@ -465,9 +468,8 @@ impl DefPathData {
fn hashed_symbol(&self) -> Option<Symbol> {
use self::DefPathData::*;
match *self {
TypeNs(name) | ValueNs(name) | MacroNs(name) | LifetimeNs(name) | AnonAssocTy(name) => {
Some(name)
}
TypeNs(name) | ValueNs(name) | MacroNs(name) | LifetimeNs(name) | AnonAssocTy(name)
| OpaqueLifetime(name) => Some(name),

Impl
| ForeignMod
Expand All @@ -486,9 +488,8 @@ impl DefPathData {
pub fn name(&self) -> DefPathDataName {
use self::DefPathData::*;
match *self {
TypeNs(name) | ValueNs(name) | MacroNs(name) | LifetimeNs(name) => {
DefPathDataName::Named(name)
}
TypeNs(name) | ValueNs(name) | MacroNs(name) | LifetimeNs(name)
| OpaqueLifetime(name) => DefPathDataName::Named(name),
// Note that this does not show up in user print-outs.
CrateRoot => DefPathDataName::Anon { namespace: kw::Crate },
Impl => DefPathDataName::Anon { namespace: kw::Impl },
Expand Down
Loading
Loading