Remove <no-bounds> on trait objects #14057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| result.connect("+") | ||
| if self.is_empty() { "".to_owned() } else { | ||
| self.iter().map(|bb| bb.user_string(tcx)).collect::<Vec<~str>>().connect("+") |
There was a problem hiding this comment.
Is there any reason to have the two cases?
There was a problem hiding this comment.
Good point. The empty case is now identical to the non-empty case.
Printing <no-bounds> on trait objects comes from a time when trait objects had a non-empty default bounds set. As they no longer have any default bounds, printing <no-bounds> is just noise.
|
@sfackler Updated |
bors
added a commit
that referenced
this pull request
May 9, 2014
Printing <no-bounds> on trait objects comes from a time when trait objects had a non-empty default bounds set. As they no longer have any default bounds, printing <no-bounds> is just noise.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 13, 2023
…else, r=jonas-schievink feat: Improve "match to let else" assist Closes rust-lang/rust-analyzer#13540 Handles complex `let` patterns (rather than just idents), and diverging block expressions have their `{`/`}` stripped to create nicer code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Printing on trait objects comes from a time when trait
objects had a non-empty default bounds set. As they no longer have any
default bounds, printing is just noise.