replace GenericArg with Term where applicable
#140320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
changes to the core type system Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
rust-cloud-vms
bot
force-pushed
the
wf-use-term
branch
from
a7585f1 to
85fa395
Compare
compiler-errors
approved these changes
Apr 26, 2025
| @@ -250,17 +250,17 @@ impl<'tcx> GenericArg<'tcx> { | |||
| } | |||
|
|
|||
| #[inline] | |||
| pub fn as_type(self) -> Option<Ty<'tcx>> { | |||
| pub fn as_region(self) -> Option<ty::Region<'tcx>> { | |||
There was a problem hiding this comment.
why did you flip these lol
There was a problem hiding this comment.
region, type, const is the correct order :<
There was a problem hiding this comment.
definitely do not agree. ty region const is the order in folders.
|
r=me after ci is green |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
|
@bors r+ approver is wrong |
|
💡 This pull request was already approved, no need to approve it again.
|
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 26, 2025
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#140215 (transmutability: Support char, NonZeroXxx) - rust-lang#140226 (Update wasm-component-ld to 0.5.13) - rust-lang#140317 (Remove redundant check) - rust-lang#140318 (Simply try to unpeel AsyncFnKindHelper goal in `emit_specialized_closure_kind_error`) - rust-lang#140320 (replace `GenericArg` with `Term` where applicable) - rust-lang#140325 (Grammar fixes for BufRead::has_data_left docs) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 26, 2025
Rollup merge of rust-lang#140320 - lcnr:wf-use-term, r=compiler-errors replace `GenericArg` with `Term` where applicable r? types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? types