Skip to content

Remove unnecessary mut in test. #139626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025
Merged

Remove unnecessary mut in test. #139626

merged 1 commit into from
Apr 10, 2025

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Apr 10, 2025

The value is moved in pin!(), so the binding doesn't need to be mut itself.

(Rustc doesn't warn about this due to the current hacky implementation of pin!(). That is fixed by #139114.)

The value is moved in pin!().
@rustbot
Copy link
Collaborator

rustbot commented Apr 10, 2025

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 10, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 10, 2025

Some changes occurred in tests/ui/sanitizer

cc @rcvalle

@lqd
Copy link
Member

lqd commented Apr 10, 2025

r? lqd @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 10, 2025

📌 Commit 95613e3 has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 10, 2025
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#139502 (fix "still mutable" ice while metrics are enabled)
 - rust-lang#139510 (Rename some `name` variables as `ident`.)
 - rust-lang#139606 (Update compiletest to Edition 2024)
 - rust-lang#139609 (compiletest: don't use stringly paths for `compose_and_run`)
 - rust-lang#139614 (Avoid empty identifiers for delegate params and args.)
 - rust-lang#139626 (Remove unnecessary `mut` in test.)
 - rust-lang#139630 (Miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9b9d098 into rust-lang:master Apr 10, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 10, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 10, 2025
Rollup merge of rust-lang#139626 - m-ou-se:mut, r=lqd

Remove unnecessary `mut` in test.

The value is moved in `pin!()`, so the binding doesn't need to be `mut` itself.

(Rustc doesn't warn about this due to the current hacky implementation of `pin!()`. That is fixed by rust-lang#139114.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants