-
Notifications
You must be signed in to change notification settings - Fork 13.3k
[WIP] mgca: Add ConstArg representation for const items #139558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
fa42f86
to
6054bd5
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ac73a4a
to
4f6c9ab
Compare
let ty = this | ||
.lower_ty(ty, ImplTraitContext::Disallowed(ImplTraitPosition::ConstTy)); | ||
let body = | ||
this.lower_const_item(span, body_id.unwrap(), expr.as_deref().unwrap()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These new unwraps should be correct in theory since an error should've already been emitted, but they might ICE if the compiler didn't stop earlier. It might be a good idea to add ConstArgKind::Err and use delayed_span_bug.
The job Click to see the possible cause of the failure (guessed by this bot)
|
r? @BoxyUwU