-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Feed HIR for by-move coroutine body def, since the inliner tries to read its attrs #139193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
28 changes: 28 additions & 0 deletions
28
tests/ui/async-await/async-closures/by-move-body-inlined-attrs.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
//@ check-pass | ||
//@ compile-flags: -Zinline-mir -Zvalidate-mir | ||
//@ edition: 2024 | ||
|
||
// See comment below. | ||
|
||
use std::future::Future; | ||
use std::pin::pin; | ||
use std::task::{Context, Waker}; | ||
|
||
fn call_once<T>(f: impl FnOnce() -> T) -> T { f() } | ||
|
||
fn main() { | ||
let x = async || {}; | ||
// We first inline `call_once<{async closure}>`. | ||
// | ||
// This gives us a future whose type is the "FnOnce" flavor of the async closure's | ||
// child coroutine. The body of this coroutine is synthetic, which we synthesize in | ||
// the by-move body query. | ||
let fut = pin!(call_once(x)); | ||
// We then try to inline that body in this poll call. | ||
// | ||
// The inliner does some inlinability checks; one of these checks involves checking | ||
// the body for the `#[rustc_no_mir_inline]` attribute. Since the synthetic body had | ||
// no HIR synthesized, but it's still a local def id, we end up ICEing in the | ||
// `local_def_id_to_hir_id` call when trying to read its attrs. | ||
fut.poll(&mut Context::from_waker(Waker::noop())); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feed_hir
both feeds thelocal_def_id_to_hir_id
query, and also the HIR attrs (as an empty list), which is fine here b/c you can't put attrs on the child coroutine anyways.