librand: Revise crypto part of document #13820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| `/dev/urandom`; kernel internally runs cryptographically secure pseudorandom | ||
| number generator (CSPRNG) based on entropy pool, so the "quality" of | ||
| `/dev/random` is not better than `/dev/urandom` in most cases. | ||
| The pitfall is when your application runs at boot time. |
There was a problem hiding this comment.
Maybe this last bit could be written "However, this means that /dev/urandom can yield somewhat predictable randomness if the entropy pool is very small, such as immediately after booting. If an application likely to be run soon after booting, or on a system with very few entropy sources, one should consider using /dev/random via ReaderRng."
This patch adds document which explains when to use `OSRng` in cryptographic context, and explains why we use `/dev/urandom` instead of `/dev/random`.
bors
added a commit
that referenced
this pull request
May 13, 2014
This patch adds document which explains when to use `OSRng` in cryptographic context, and explains why we use `/dev/urandom` instead of `/dev/random`.
arcnmx
pushed a commit
to arcnmx/rust
that referenced
this pull request
Jan 9, 2023
Fix binding mode hints always adding parentheses to or-patterns
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 26, 2024
Looks like typo for me. Looking at blame rust-lang/rust-clippy@b76b0ae#diff-ac15e787d7d276b24f251f4f5bdedf1e6ac81aa1e2ea0db27219e9a7fa8b0b30L66 the same typo was before. Is logic here actually correct? Tests passed locally, but i expected some changes. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds document which explains when to use
OSRngincryptographic context, and explains why we use
/dev/urandominsteadof
/dev/random.