Fix ICE when reporting closure and proc mismatch #13657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let _xs = nums.map(proc(n) {n * 2}); //~ ERROR mismatched types | ||
|
|
||
| spawn(|| {}); //~ ERROR mismatched types | ||
| } |
There was a problem hiding this comment.
Could you expand these error messages a bit more to have some more of the message itself? I've also found it useful to minimize test cases to just this one file (as little dependence on libstd) if possible (but not necessary)
|
r? |
| //~^ ERROR mismatched types: expected `||` but found `proc()` (expected closure, found proc) | ||
|
|
||
| expect_proc(|| {}); | ||
| //~^ ERROR mismatched types: expected `proc()` but found `once ||` (expected proc, found closure) |
There was a problem hiding this comment.
This error seems a bit misleading because I think most aren't aware that once || is even a thing (it's feature gated anyway). Perhaps we could remove the expected_onceness argument (in check_expr_fn above)? That looks like it may print the right thing at that point.
There was a problem hiding this comment.
It is a little bit more complicated than that. Fixed.
bors
added a commit
that referenced
this pull request
Apr 22, 2014
flip1995
added a commit
to flip1995/rust
that referenced
this pull request
Nov 7, 2024
…s-to-early collect attribute spans early for disallowed macros
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13599