-
Notifications
You must be signed in to change notification settings - Fork 13.3k
fix: correct typos and improve comments in compiler code #136384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
RubinovaAn1097
commented
Feb 1, 2025
- Replaced “unstalled” with “uninstalled” and “thie” → “this” in comments.
- Fixed “replacable” to “replaceable.”
- Tweaked wording in a few spots for clarity.
- No logic changes—just doc/comment updates.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @lcnr (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
The Miri subtree was changed cc @rust-lang/miri Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
The job Click to see the possible cause of the failure (guessed by this bot)
|
We have gotten a number of typo-fixing PRs recently that look like either identify farming or seeking of extrinsic rewards. This looks like one of those, especially because it doesn't compile, and one of the changes is wrong. |
In particular, "unstalled" is an actual word, meaning "not stalled" or "no longer stalled".
|
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
hello! sorry for any confusion, but we actually are treating it on the merit. we have plenty of typos in our user-facing documentation for which we are always happy to accept PRs for, but typo fixes that are confined to a random smattering of internal compiler comments are not useful. they are in fact churn that outweighs the benefit. |