-
Notifications
You must be signed in to change notification settings - Fork 13.3k
add support for quadruple precision floating point #13415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm in favour, but I would guess a change like this is theoretically meant to go through an RFC. (That said, since it's small change & is feature gated, I would personally be ok with merging and then going through an RFC to un-feature-gate.) |
I'm a little worried about adding a new primitive type to the language without an RFC and without any documentation. The implementation seems ok with me, but this is quite a change to the language which hasn't had much discussion. |
It has actually been discussed a long time ago since it was Graydon's reason for having |
We decided in today's meeting to move forward with this, r=me with a rebase. |
Or no, before merging, I had one concern. This feature is enabled in libstd, and looks like it's only used by the visitor. By enabling this feature, are we pulling in runtime support which may not be available on all platforms? (my worry is just libstd, not f128 usage in general) |
@alexcrichton: No runtime support is required to enable it in libstd and define some stuff like constants in an At the moment, compiler-rt only has portable implementations of the comparison operators. I don't think any change needing more than those will make it through the OS X and Android bots. |
OK, sounds good to me! |
This currently requires linking against a library like libquadmath (or libgcc), because compiler-rt barely has any support for this and most hardware does not yet have 128-bit precision floating point. For this reason, it's currently hidden behind a feature gate. When compiler-rt is updated to trunk, some tests can be added for constant evaluation since there will be support for the comparison operators. Closes #13381
This currently requires linking against a library like libquadmath (or libgcc), because compiler-rt barely has any support for this and most hardware does not yet have 128-bit precision floating point. For this reason, it's currently hidden behind a feature gate. When compiler-rt is updated to trunk, some tests can be added for constant evaluation since there will be support for the comparison operators. Closes #13381
internal: Set a timeout when publishing to OVSX CC rust-lang/rust-analyzer#11080 (comment)
…lip1995 End my vacation r? `@ghost` changelog: none
This currently requires linking against a library like libquadmath (or
libgcc), because compiler-rt barely has any support for this and most
hardware does not yet have 128-bit precision floating point. For this
reason, it's currently hidden behind a feature gate.
When compiler-rt is updated to trunk, some tests can be added for
constant evaluation since there will be support for the comparison
operators.
Closes #13381