Skip to content

rustc_transmute: Directly use types from rustc_abi #132248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

workingjubilee
Copy link
Member

@workingjubilee workingjubilee commented Oct 28, 2024

Using the reexport from rustc_target is not necessary here, so use rustc_abi directly.

@rustbot
Copy link
Collaborator

rustbot commented Oct 28, 2024

Failed to set assignee to jswrenn: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 28, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 28, 2024

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@workingjubilee
Copy link
Member Author

well!

r? compiler

@compiler-errors
Copy link
Member

r=me when green

@workingjubilee
Copy link
Member Author

@bors rollup

@workingjubilee
Copy link
Member Author

@bors r=compiler-errors

@bors
Copy link
Collaborator

bors commented Oct 28, 2024

📌 Commit 2720706 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2024
@RalfJung
Copy link
Member

Should we get rid of these reexports? RA isn't great at dealing with them so it often ends up adding the rustc_abi imports... and then we get build failures since that crate isn't listed as a dependency.

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 28, 2024
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#131391 (Stabilize `isqrt` feature)
 - rust-lang#132248 (rustc_transmute: Directly use types from rustc_abi)
 - rust-lang#132252 (compiler: rename LayoutS to LayoutData)
 - rust-lang#132253 (Known-bug test for `keyword_idents` lint not propagating to other files)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f62ed5e into rust-lang:master Oct 28, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Oct 28, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 28, 2024
Rollup merge of rust-lang#132248 - workingjubilee:add-rustc-abi-to-transmute, r=compiler-errors

rustc_transmute: Directly use types from rustc_abi

Using the reexport from rustc_target is not necessary here, so use rustc_abi directly.
@workingjubilee workingjubilee deleted the add-rustc-abi-to-transmute branch October 28, 2024 17:36
@workingjubilee
Copy link
Member Author

Should we get rid of these reexports? RA isn't great at dealing with them so it often ends up adding the rustc_abi imports... and then we get build failures since that crate isn't listed as a dependency.

...well, we want the rustc_abi imports. It's the rustc_target reexports that we don't want.

@workingjubilee
Copy link
Member Author

But yes incrementing towards the final state where rustc_target reexports nothing, at least publicly, from rustc_abi, is the primary aim of most of my recent flurry of PRs.

@RalfJung
Copy link
Member

RalfJung commented Oct 28, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants