Remind the programmer to use () for method calls #12937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How is "maybe a missing the parens are wrapped in backticks, but github escaping kinda sucks. |
|
@sinistersnare That's good. |
|
OK, added test. I think this is good. r? |
bors
added a commit
that referenced
this pull request
Mar 17, 2014
its a common (yet easily fixable) error to just forget parens at the end of getter-like methods without any arguments. The current error message for that case asks for an anonymous function, this patch adds a note asking for either an anonymous function, or for trailing parens. This is my first contribution! do i need to do anything else?
|
Thanks so much @huonw for the help! That was awesome! |
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Aug 16, 2022
Add fixups for incomplete in proc-macros Partially implements rust-lang/rust-analyzer#12777. Added support for for loops and match statements. I couldn't do paths like `crate::foo::` as I wasn't able to add `SyntheticTokens` to the end of `foo::`, they always ended up after `crate::` This is my first contribution so please don't be shy about letting me know if I've done anything wrong!
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 27, 2024
…r_comparison, r=Alexendoo Add MSRV for manual_pattern_char_comparison Fixes rust-lang#12936 changelog: [`manual_pattern_char_comparison`]: Add MSRV 1.58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
its a common (yet easily fixable) error to just forget parens at the end of getter-like methods without any arguments.
The current error message for that case asks for an anonymous function, this patch adds a note asking for either an anonymous function, or for trailing parens.
This is my first contribution! do i need to do anything else?