copy rustlib sources instead of using symbolic links #127151
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: onur-ozkan <[email protected]>
There are certain cases where we need to add things to the rustlib source paths in CI builders. When the rustlib sources are symbolically linked to `/checkout`, we can't make any modifications because `/checkout` is mounted as read-only in containers. This change updates the bootstrap to copy the rustlib directories instead of linking them, so we can put/link things into rustlib directories when needed. Signed-off-by: onur-ozkan <[email protected]>
rustbot
added
S-waiting-on-review
onur-ozkan
commented
Jun 30, 2024
Comment on lines
1630
to
1631
| // and also for translating the virtual `/rustc/$hash` back to the real | ||
| // directory (for running tests with `rust.remap-debuginfo = true`). |
There was a problem hiding this comment.
I am not sure if this is going to change.
There was a problem hiding this comment.
Future note for worst-case scenario: We can make this to use copying for CI environments and create symbolic links for non-CI environments.
|
It seems like this isn't going to work.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are certain cases where we need to add things to the rustlib source paths in CI builders. When the rustlib sources are symbolically linked to
/checkout, we can't make any modifications because/checkoutis mounted as read-only in containers. This change updates the bootstrap to copy the rustlib directories instead of linking them, so we can put/link things into rustlib directories when needed.r? @Kobzol (we talked about this already on Zulip, he knows the context)
Blocker for #122709