Reword the caveats on array::map
#126100
Open
Reword the caveats on array::map
#126100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to 107634 and some improvements in LLVM (particularly `dead_on_unwind`), the method actually optimizes reasonably well now. So focus the discussion on the fundamental ordering differences where the optimizer might never be able to fix it because of the different behaviour, and encouraging `Iterator::map` where an array wasn't actually ever needed.
rustbot
added
S-waiting-on-review
the8472
reviewed
Jun 6, 2024
Comment on lines
+468
to
+470
| /// That means that `arr.map(f).map(g)` is, in general, *not* equivalent to | ||
| /// `array.map(|x| g(f(x)))`, as the former calls `f` 4 times then `g` 4 times, | ||
| /// whereas the latter interleaves the calls (`fgfgfgfg`). |
There was a problem hiding this comment.
We shouldn't be talking about iterator evaluation order. E.g. next_chunk impls may evaluate like array.map and so any iterator method that uses chunking internally might also use that order.
There was a problem hiding this comment.
That wasn't meant to reject the update to map. I just meant that we shouldn't be referring to Iterator order since the latter depends on the implementation. No such concern applies to the array method since it's evaluated eagerly and there's no possibility of specializing that.
scottmcm
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to #107634 and some improvements in LLVM (particularly
dead_on_unwind), the method actually optimizes reasonably well now.So focus the discussion on the fundamental ordering differences where the optimizer might never be able to fix it because of the different behaviour, and keep encouraging
Iterator::mapwhere an array wasn't actually ever needed.