Fix copy path button #124041
Merged
Fix copy path button #124041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could not assign reviewer from: |
|
@GuillaumeGomez: no appropriate reviewer found, use |
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @jsha |
This comment has been minimized.
This comment has been minimized.
notriddle
requested changes
Apr 16, 2024
|
|
||
| #copy-path:before { | ||
| #copy-path.clicked { | ||
| font-size: 26px; |
There was a problem hiding this comment.
This seems pretty fragile. It's dependent on font metrics to avoid making the button jump around, so you can easily mess it up and get layout jank.
Instead of using a text checkmark, could you use the SVG checkmark? That way, the .clicked class can change the content: url and nothing else, so it's obvious that it won't change the layout?
There was a problem hiding this comment.
That's what I did originally but the checkmark svg is pretty ugly in this context. I'll look for another one instead.
rustbot
added
S-waiting-on-author
GuillaumeGomez
force-pushed
the
fix-copy-path-button
branch
from
8a69956 to
1ebc9ef
Compare
|
Changed the checkmark to svg. The CSS is much simpler now. :) |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 18, 2024
…n, r=notriddle Fix copy path button Currently, on all nightly docs, clicking on the "copy path" button triggers a JS error. It's because changes in rust-lang#123706 forgot to update the JS (it contained an image before but not anymore). I had to make some small changes in the CSS to fix the display when the button was clicked as well. r? `@notriddle`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 18, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#124041 (Fix copy path button) - rust-lang#124047 (Match ergonomics 2024: miscellaneous code cleanups) - rust-lang#124064 (Move confusing comment about otherwise blocks in `lower_match_tree`) - rust-lang#124072 (Remove libc from more tests) - rust-lang#124090 (llvm: update riscv target feature to match LLVM 19) - rust-lang#124100 (fix: make `str::from_raw_parts_mut` `mut`) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 18, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#124041 (Fix copy path button) - rust-lang#124047 (Match ergonomics 2024: miscellaneous code cleanups) - rust-lang#124064 (Move confusing comment about otherwise blocks in `lower_match_tree`) - rust-lang#124090 (llvm: update riscv target feature to match LLVM 19) - rust-lang#124100 (fix: make `str::from_raw_parts_mut` `mut`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 18, 2024
Rollup merge of rust-lang#124041 - GuillaumeGomez:fix-copy-path-button, r=notriddle Fix copy path button Currently, on all nightly docs, clicking on the "copy path" button triggers a JS error. It's because changes in rust-lang#123706 forgot to update the JS (it contained an image before but not anymore). I had to make some small changes in the CSS to fix the display when the button was clicked as well. r? ``@notriddle``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, on all nightly docs, clicking on the "copy path" button triggers a JS error. It's because changes in #123706 forgot to update the JS (it contained an image before but not anymore).
I had to make some small changes in the CSS to fix the display when the button was clicked as well.
r? @notriddle