Skip to content

Change xfail directives in compiletests to ignore, closes #11363 #12110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion mk/tests.mk
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ ifdef TESTNAME
TESTARGS += $(TESTNAME)
endif

ifdef CHECK_XFAILS
ifdef CHECK_IGNORED
TESTARGS += --ignored
endif

Expand Down
2 changes: 1 addition & 1 deletion src/compiletest/compiletest.rs
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ pub fn parse_config(args: ~[~str]) -> config {
reqopt("", "stage-id", "the target-stage identifier", "stageN-TARGET"),
reqopt("", "mode", "which sort of compile tests to run",
"(compile-fail|run-fail|run-pass|pretty|debug-info)"),
optflag("", "ignored", "run tests marked as ignored / xfailed"),
optflag("", "ignored", "run tests marked as ignored"),
optopt("", "runtool", "supervisor program to run tests under \
(eg. emulator, valgrind)", "PROGRAM"),
optopt("", "rustcflags", "flags to pass to rustc", "FLAGS"),
Expand Down
16 changes: 8 additions & 8 deletions src/compiletest/header.rs
Original file line number Diff line number Diff line change
Expand Up @@ -95,19 +95,19 @@ pub fn load_props(testfile: &Path) -> TestProps {
}

pub fn is_test_ignored(config: &config, testfile: &Path) -> bool {
fn xfail_target(config: &config) -> ~str {
~"xfail-" + util::get_os(config.target)
fn ignore_target(config: &config) -> ~str {
~"ignore-" + util::get_os(config.target)
}
fn xfail_stage(config: &config) -> ~str {
~"xfail-" + config.stage_id.split('-').next().unwrap()
fn ignore_stage(config: &config) -> ~str {
~"ignore-" + config.stage_id.split('-').next().unwrap()
}

let val = iter_header(testfile, |ln| {
if parse_name_directive(ln, "xfail-test") { false }
else if parse_name_directive(ln, xfail_target(config)) { false }
else if parse_name_directive(ln, xfail_stage(config)) { false }
if parse_name_directive(ln, "ignore-test") { false }
else if parse_name_directive(ln, ignore_target(config)) { false }
else if parse_name_directive(ln, ignore_stage(config)) { false }
else if config.mode == common::mode_pretty &&
parse_name_directive(ln, "xfail-pretty") { false }
parse_name_directive(ln, "ignore-pretty") { false }
else { true }
});

Expand Down
8 changes: 4 additions & 4 deletions src/etc/combine-tests.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2011-2013 The Rust Project Developers. See the COPYRIGHT
# Copyright 2011-2014 The Rust Project Developers. See the COPYRIGHT
# file at the top-level directory of this distribution and at
# http://rust-lang.org/COPYRIGHT.
#
Expand Down Expand Up @@ -36,9 +36,9 @@ def scrub(b):
t.startswith(".") or t.startswith("#") or t.startswith("~")):
f = codecs.open(os.path.join(run_pass, t), "r", "utf8")
s = f.read()
if not ("xfail-test" in s or
"xfail-fast" in s or
"xfail-win32" in s):
if not ("ignore-test" in s or
"ignore-fast" in s or
"ignore-win32" in s):
if not "pub fn main" in s and "fn main" in s:
print("Warning: no public entry point in " + t)
stage2_tests.append(t)
Expand Down
2 changes: 1 addition & 1 deletion src/etc/extract-tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def extract_code_fragments(dest_dir, lines):
block.appendleft(OUTPUT_BLOCK_HEADER)

if "ignore" in tags:
block.appendleft("//xfail-test\n")
block.appendleft("//ignore-test\n")
elif "should_fail" in tags:
block.appendleft("//should-fail\n")

Expand Down
6 changes: 3 additions & 3 deletions src/etc/licenseck.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2013 The Rust Project Developers. See the COPYRIGHT
# Copyright 2013-2014 The Rust Project Developers. See the COPYRIGHT
# file at the top-level directory of this distribution and at
# http://rust-lang.org/COPYRIGHT.
#
Expand Down Expand Up @@ -52,12 +52,12 @@ def check_license(name, contents):

# Xfail check
firstlineish = contents[:100]
if firstlineish.find("xfail-license") != -1:
if firstlineish.find("ignore-license") != -1:
return True

# License check
boilerplate = contents[:500]
if (boilerplate.find(license1) == -1 or boilerplate.find(license2) == -1) and \
(boilerplate.find(license3) == -1 or boilerplate.find(license4) == -1):
return False
return True
return True
6 changes: 3 additions & 3 deletions src/etc/tidy.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@

err=0
cols=100
cr_flag="xfail-tidy-cr"
tab_flag="xfail-tidy-tab"
linelength_flag="xfail-tidy-linelength"
cr_flag="ignore-tidy-cr"
tab_flag="ignore-tidy-tab"
linelength_flag="ignore-tidy-linelength"

# Be careful to support Python 2.4, 2.6, and 3.x here!
config_proc=subprocess.Popen([ "git", "config", "core.autocrlf" ],
Expand Down
4 changes: 2 additions & 2 deletions src/libgreen/sched.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// Copyright 2013-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand Down Expand Up @@ -1364,7 +1364,7 @@ mod test {
});
}

// FIXME: #9407: xfail-test
// FIXME: #9407: ignore-test
#[ignore]
#[test]
fn dont_starve_1() {
Expand Down
4 changes: 2 additions & 2 deletions src/test/auxiliary/crateresolve7x.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
// Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand All @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-fast
// ignore-fast
// aux-build:crateresolve_calories-1.rs
// aux-build:crateresolve_calories-2.rs

Expand Down
4 changes: 2 additions & 2 deletions src/test/auxiliary/issue-2414-b.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
// Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand All @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-fast
// ignore-fast

#[crate_id="b#0.1"];
#[crate_type = "lib"];
Expand Down
4 changes: 2 additions & 2 deletions src/test/auxiliary/issue-9906.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// Copyright 2013-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand All @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-fast windows doesn't like extern mod
// ignore-fast windows doesn't like extern mod
// aux-build:issue-9906.rs

pub use other::FooBar;
Expand Down
4 changes: 2 additions & 2 deletions src/test/bench/core-set.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// xfail-pretty
// ignore-pretty

// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// Copyright 2013-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand Down
2 changes: 1 addition & 1 deletion src/test/bench/shootout-fannkuch-redux.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-test reading from os::args()[1] - bogus!
// ignore-test reading from os::args()[1] - bogus!

use std::from_str::FromStr;
use std::os;
Expand Down
2 changes: 1 addition & 1 deletion src/test/bench/shootout-fasta-redux.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-test reading from os::args()[1] - bogus!
// ignore-test reading from os::args()[1] - bogus!

use std::cast::transmute;
use std::from_str::FromStr;
Expand Down
6 changes: 3 additions & 3 deletions src/test/bench/shootout-k-nucleotide-pipes.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
// Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand All @@ -8,9 +8,9 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-android: FIXME(#10393)
// ignore-android: FIXME(#10393)

// xfail-pretty the `let to_child` line gets an extra newline
// ignore-pretty the `let to_child` line gets an extra newline
// multi tasking k-nucleotide

extern mod extra;
Expand Down
2 changes: 1 addition & 1 deletion src/test/bench/shootout-k-nucleotide.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-test
// ignore-test

extern mod extra;

Expand Down
4 changes: 2 additions & 2 deletions src/test/bench/shootout-reverse-complement.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// Copyright 2013-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand All @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-android doesn't terminate?
// ignore-android doesn't terminate?

use std::iter::range_step;
use std::io::{stdin, stdout, File};
Expand Down
4 changes: 2 additions & 2 deletions src/test/bench/shootout-spectralnorm.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2012-2013 The Rust Project Developers. See the COPYRIGHT
// Copyright 2012-2013-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand All @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-test arcs no longer unwrap
// ignore-test arcs no longer unwrap

extern mod sync;

Expand Down
4 changes: 2 additions & 2 deletions src/test/bench/sudoku.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// xfail-pretty
// ignore-pretty

// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
// Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand Down
4 changes: 2 additions & 2 deletions src/test/bench/task-perf-jargon-metal-smoke.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// xfail-pretty
// ignore-pretty

// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
// Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand Down
6 changes: 3 additions & 3 deletions src/test/bench/task-perf-linked-failure.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-pretty
// xfail-test linked failure
// ignore-pretty
// ignore-test linked failure

// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
// Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand Down
4 changes: 2 additions & 2 deletions src/test/bench/task-perf-one-million.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
// Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand All @@ -10,7 +10,7 @@

// Test for concurrent tasks

// xfail-test OOM on linux-32 without opts
// ignore-test OOM on linux-32 without opts

use std::os;
use std::task;
Expand Down
4 changes: 2 additions & 2 deletions src/test/compile-fail/ambig_impl_2_exe.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
// Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand All @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-fast aux-build
// ignore-fast aux-build
// aux-build:ambig_impl_2_lib.rs
extern mod ambig_impl_2_lib;
use ambig_impl_2_lib::me;
Expand Down
4 changes: 2 additions & 2 deletions src/test/compile-fail/asm-in-bad-modifier.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2012-2013 The Rust Project Developers. See the COPYRIGHT
// Copyright 2012-2013-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand All @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-fast #[feature] doesn't work with check-fast
// ignore-fast #[feature] doesn't work with check-fast
#[feature(asm)];

fn foo(x: int) { info!("{}", x); }
Expand Down
4 changes: 2 additions & 2 deletions src/test/compile-fail/asm-out-assign-imm.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2012-2013 The Rust Project Developers. See the COPYRIGHT
// Copyright 2012-2013-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand All @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-fast #[feature] doesn't work with check-fast
// ignore-fast #[feature] doesn't work with check-fast
#[feature(asm)];

fn foo(x: int) { info!("{}", x); }
Expand Down
4 changes: 2 additions & 2 deletions src/test/compile-fail/asm-out-no-modifier.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2012-2013 The Rust Project Developers. See the COPYRIGHT
// Copyright 2012-2013-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand All @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-fast #[feature] doesn't work with check-fast
// ignore-fast #[feature] doesn't work with check-fast
#[feature(asm)];

fn foo(x: int) { info!("{}", x); }
Expand Down
4 changes: 2 additions & 2 deletions src/test/compile-fail/asm-out-read-uninit.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2012-2013 The Rust Project Developers. See the COPYRIGHT
// Copyright 2012-2013-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand All @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-fast #[feature] doesn't work with check-fast
// ignore-fast #[feature] doesn't work with check-fast
#[feature(asm)];

fn foo(x: int) { info!("{}", x); }
Expand Down
4 changes: 2 additions & 2 deletions src/test/compile-fail/bad-char-literals3.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// Copyright 2013-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand All @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-tidy-cr
// ignore-tidy-cr
fn main() {
// note that this is a literal "\r" byte
'
Expand Down
Loading