Rearranged enum section of tutorial for clarity. #12060
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -682,12 +659,20 @@ enum Direction { | |||
| } | |||
| ~~~~ | |||
|
|
|||
| This declaration defines `North`, `East`, `South`, and `West` as constants, | |||
| all of which have type `Direction`. | |||
| Each variant of this C-like enum has a unique discriminator value. If no | |||
There was a problem hiding this comment.
Needs an explanation of why this is C-like.
|
r+ with above comment addressed |
|
Good point. There's no need to write "C-like". This version is more explicit about what really happens. |
This version starts with the simple case and builds on it.
|
This version passes tests locally. |
bors
added a commit
that referenced
this pull request
Feb 10, 2014
…excrichton This version starts with the simplest case and builds on it. I believe it flows better.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
minor: Simplify bors r+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version starts with the simplest case and builds on it. I believe it flows better.