Test runner displays colors even when running in parallel, closes #9388, #782 #11689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, #782 By wrapping `io::stdio()` with `LineBufferedWriter`, it is guaranteed `write` is called only once per lines. I also added `flush` method in order to display a `test <testname> ...` message before the test begins to run. This message helps you to know the progress.
|
Sadly, this isn't the blocker for writing colors in tests. Right now if you have concurrent prints in tests (via stdio or stderr) the color delimiters will get mixed up and pollute the output even further. We'd need to capture the child task's stdout/stderr in order to be able to safely use colors when running tests. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 16, 2023
…al_memcpy-when-array-length-is-equal-to-range, r=blyxyas fix: [manual_memcpy] reduce indexing suggestions when array length is equal to loop range fixes: rust-lang#11689 This PR improves `manual_memcpy` suggestions by reducing unnecessary indexing. For example, ```rust let src = [0, 1, 2, 3, 4]; let mut dest = [0; 4]; for i in 0..4 { dest[i] = src[i]; { ``` Clippy suggests `dest[..4].copy_from_slice(&src[..4]);`. I reduced this suggestion as `dest.copy_from_slice(&src[..4]);`. (Removed needless indexing.) changelog: [`manual_memcpy`]: Reduce indexing suggestions when array length is equal to loop range
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By wrapping
io::stdio()withLineBufferedWriter, it is guaranteedwriteis called only once per lines.I also added
flushmethod in order to display atest <testname> ...message before the test begins to run. This message helps you to know the progress.