Fix cross-compiled pretty tests #11675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They need to read the metadata of cross-compiled crates, so the pretty things need to have the right target.
bors
added a commit
that referenced
this pull request
Jan 20, 2014
They need to read the metadata of cross-compiled crates, so the pretty things need to have the right target.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 2, 2024
…nly, r=xFrednet reduce `single_char_pattern` to only lint on ascii chars This should mostly fix the `single_char_pattern` lint, because with a single byte, the optimizer will usually see through the char-to-string-expansion and single loop iteration. This fixes rust-lang#11675 and rust-lang#8111. Update: As per the meeting on November 28th, 2023, we voted to also downgrade the lint to pedantic. --- changelog: downgrade [`single_char_pattern`] to `pedantic`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They need to read the metadata of cross-compiled crates, so the pretty things
need to have the right target.