Force all lang items to be reachable #11603
Conversation
|
I'm not sure I agree with this. I had always assumed that lang items should be pub, and that the compiler was wrong in the referenced issue to try to use a lang item that can't be reached. I do see the appeal of being able to hide the details of some of our lang items. Anybody else have an opinion? |
|
@brson: I think hiding these would be great. They're low-level implementation details and don't belong as accessible public functions at all in my opinion. The interfaces are not thought out and are generally just whatever was easy enough to implement. |
|
There are lots of public interfaces that aren't lang items that we don't want to commit to, and we have attributes for communicating that. |
|
There's a difference between an interface without a stability guarantee and an implementation detail. Exposing implementation details without a reason to do it is just making the API needlessly complex. |
|
I'm coming around to the idea that we should make it harder to access intrinsics and lang items directly. Not opposed to this but would still like more opinions from the core team. |
This prevents linker errors as found in rust-lang#11591 Closes rust-lang#11591
Fix: avoid changing drop order Fixes rust-lang/rust-clippy#11599 changelog: [`redundant_locals`] No longer lints which implements Drop trait to avoid reordering
This prevents linker errors as found in #11591
Closes #11591