-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Avoid a source_span
query when encoding Spans into query results
#115657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
encode_query_cache(tcx, e) | ||
}); | ||
}); | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are blocks swapped?
Should this block be wrapped inside a dep_graph.with_query_deserialization
to ICE if a query is invoked?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typeck
and mir_borrowck
still use queries in their cache_on_disk_if
block, so that cannot be used yet. This block order can cause panics due to GraphEncoder
being stolen though, so it will catch query execution at least.
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (38bbc2c): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 629.42s -> 628.91s (-0.08%) |
@rustbot label: +perf-regression-triaged |
This avoids a
source_span
query when encodingSpan
s into query results. It's not sound to execute queries here as the query caches can be locked and the dep graph is no longer writable.r? @cjgillot