#6615 - Added a better error message for --ls #11544
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Looking at For example the first one (where |
|
Alright I will get on it, and update my pull request. |
|
Thanks, @rgawdzik! |
|
Closing due to inactivity, but feel free to reopen with a rebase! I'd love to get this fixed... |
|
Yeah really busy, sorry. Will find time later. |
bors
added a commit
that referenced
this pull request
Mar 9, 2014
Refactored get_metadata_section to return a Result<MetadataBlob,~str> instead of a Option<MetadataBlob>. This provides more clarity to the user through the debug output when using --ls. This is kind of a continuation of my original closed pull request 2 months ago (#11544), but I think the time-span constitutes a new pull request.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Sep 25, 2023
Remove most usage of `hir_ty_to_ty` Removes the usages where there's a suitable query or the type was already available elsewhere. The remaining cases would all require more involved changes changelog: none r? `@Jarcho`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first pull request, made the error message better to close #6615.