Skip to content

update Miri #115049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

update Miri #115049

wants to merge 12 commits into from

Conversation

RalfJung
Copy link
Member

r? @ghost

RalfJung and others added 11 commits August 17, 2023 13:48
tree borrows: more comments in foreign_read transition
pin a version of serde without intransparent unreproducible binary blobs

Serde is [shipping a binary blob in its derive crate](serde-rs/serde#2538), which is highly unexpected and subverts user trust. To make matters worse, the binary is [not even reproducible](serde-rs/serde#2575), making the crate largely unauditable and relinquishing the security benefits of open-source software. Build times are not nearly painful enough to justify forcing users to trust binary blobs.
update recommended RA config

Looks like rust-analyzer.checkOnSave.overrideCommand got renamed to rust-analyzer.check.overrideCommand.
@rustbot
Copy link
Collaborator

rustbot commented Aug 21, 2023

The Miri subtree was changed

cc @rust-lang/miri

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 21, 2023
@rustbot
Copy link
Collaborator

rustbot commented Aug 21, 2023

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@RalfJung
Copy link
Member Author

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 21, 2023

📌 Commit 9a3cb9e has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 21, 2023
@bors
Copy link
Collaborator

bors commented Aug 21, 2023

⌛ Testing commit 9a3cb9e with merge 6f2e42eb241c024fbe8b31e804d25a13a9c04be2...

@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[RUSTC-TIMING] tracing_log test:false 3.638
   Compiling rustc_macros v0.1.0 (/checkout/compiler/rustc_macros)
[RUSTC-TIMING] syn test:false 17.070
   Compiling zerofrom-derive v0.1.2
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
   Compiling yoke-derive v0.7.1

##[group]Clock drift check
  local time: Tue Aug 22 00:02:00 UTC 2023
  local time: Tue Aug 22 00:02:00 UTC 2023
  network time: Tue, 22 Aug 2023 00:02:00 GMT
##[endgroup]
Session terminated, killing shell...[RUSTC-TIMING] aho_corasick test:false 11.623
 ...killed.
 ...killed.
time="2023-08-22T00:02:02Z" level=error msg="error waiting for container: unexpected EOF"
##[error]The operation was canceled.

@bors
Copy link
Collaborator

bors commented Aug 22, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 22, 2023
@RalfJung
Copy link
Member Author

RalfJung commented Aug 22, 2023 via email

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 22, 2023
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 22, 2023
@bors
Copy link
Collaborator

bors commented Aug 22, 2023

⌛ Testing commit 9a3cb9e with merge 16349a8d7a7f12844eb5506ba8099ac1e70b541a...

@rust-log-analyzer
Copy link
Collaborator

The job armhf-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
failures:

---- [ui] tests/ui/rfcs/rfc-2091-track-caller/caller-location-intrinsic.rs#mir-opt stdout ----

error in revision `mir-opt`: test run failed!
command: RUST_TEST_THREADS="8" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/remote-test-client" "run" "0" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfcs/rfc-2091-track-caller/caller-location-intrinsic.mir-opt/a"
--- stdout -------------------------------
--- stdout -------------------------------
uploaded "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfcs/rfc-2091-track-caller/caller-location-intrinsic.mir-opt/a", waiting for result
--- stderr -------------------------------
thread 'main' panicked at 'client.read_exact(&mut header) failed with Connection reset by peer (os error 104)', src/tools/remote-test-client/src/main.rs:310:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
------------------------------------------

@bors
Copy link
Collaborator

bors commented Aug 22, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 22, 2023
@RalfJung RalfJung closed this Aug 22, 2023
@RalfJung RalfJung deleted the miri branch August 22, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants