-
Notifications
You must be signed in to change notification settings - Fork 13.4k
remove builtin Copy
and Clone
impl for float and int infer
#114739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @b-naber (rustbot has picked a reviewer for you, use r? to override) |
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit bb76fde with merge 4f9805ec4702c97302dd8116b6f848c194756acc... |
Copy
and Clone
impl for float and int infer
Copy
and Clone
impl for float and int inferCopy
and Clone
impl for float and int infer
r=me if perf comes back good, this doesn't seem to me like something that should cause issues other than possibly changing the order that we process obligations, which isn't guaranteed anyways. |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (4f9805ec4702c97302dd8116b6f848c194756acc): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 632.877s -> 633.23s (0.06%) |
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (49af618): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 632.358s -> 633.298s (0.15%) |
it's only change is whether
{integer}: Copy
is ambiguous, this has the following properties#[no_core]
Clone
has user-facing differences from other traits fromcore
with the new solver because it can potentially guide inference there