-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Gracefully handle ternary operator #114028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @davidtwco (rustbot has picked a reviewer for you, use r? to override) |
f3f725e
to
cd583e0
Compare
cd583e0
to
0e73220
Compare
This comment has been minimized.
This comment has been minimized.
0e73220
to
1648180
Compare
gotta do a perf run cause parser is larger @bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit faa7395 with merge bd6b819d60ffdfdba3010b39e4097b59d1aafb85... |
I actually just removed the |
282a7dc
to
79b6ed0
Compare
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (a04e649): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 651.386s -> 652.746s (0.21%) |
Fixes #112578
May not be the best way to do this as it doesn't check for a single:
, so it could perhaps appear even when the actual issue is just a missing semicolon. May not be the biggest deal, though?Nevermind, got it working properly now ^^