-
Notifications
You must be signed in to change notification settings - Fork 13.4k
couple of clippy::style changes #113978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
couple of clippy::style changes #113978
Conversation
matthiaskrgr
commented
Jul 23, 2023
r? @eholk (rustbot has picked a reviewer for you, use r? to override) |
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
compiler/rustc_hir/src/hir.rs
Outdated
@@ -3014,7 +3014,7 @@ impl FieldDef<'_> { | |||
// Still necessary in couple of places | |||
pub fn is_positional(&self) -> bool { | |||
let first = self.ident.as_str().as_bytes()[0]; | |||
(b'0'..=b'9').contains(&first) | |||
first.is_ascii_digit() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first.is_ascii_digit() | |
self.ident.as_str().as_bytes()[0].is_ascii_digit() |
s.push_str(&v.join(", ")); | ||
s.push_str("]"); | ||
s.push(']'); | ||
s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s | |
format!("[{}]", v.join(", ")) |
r? @fee1-dead |
comparison_to_empty iter_nth_zero for_kv_map manual_next_back redundant_pattern
get_first single_char_add_str unnecessary_mut_passed manual_map manual_is_ascii_check
e949a3a
to
af2b370
Compare
@rustbot ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bors r+ rollup
@bors r+ rollup |
☀️ Test successful - checks-actions |
Finished benchmarking commit (155a5c2): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 652.153s -> 652.237s (0.01%) |