-
Notifications
You must be signed in to change notification settings - Fork 13.3k
aarch64-msvc: remove CI hack for bad Windows SDK version #113854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
See https://github.com/rust-lang-ci/rust/actions/runs/5596259246/jobs/10233070602#step:24:929 C:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\ucrt\corecrt_io.h
(rustbot has picked a reviewer for you, use r? to override) |
056fcb0
to
8680f31
Compare
This comment has been minimized.
This comment has been minimized.
8680f31
to
e947bd7
Compare
Ok, builded successfully https://github.com/rust-lang/rust/actions/runs/5598315458/jobs/10237804937?pr=113854 (failed to upload attracts, but that's doesn't related, guess). Should i add note somewhere about bad windows sdk version, or left as it is? |
I think this is fine as-is. @bors r+ |
@bors rollup=iffy |
☀️ Test successful - checks-actions |
Finished benchmarking commit (fe90d7d): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: missing data |
This removes hack which manually replaced windows sdk version, as it looks like useless now, as CI uses newer version: https://github.com/rust-lang-ci/rust/actions/runs/5596259246/jobs/10233070602#step:24:929
C:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\ucrt\corecrt_io.h
(look at version)related #88796
It's nice to have some way to assert bad version, but i don't see anything except checking env rust-lang/cc-rs#646