remove constant evaluation hack in super_relate_consts

[BoxyUwU]

super_relate_consts has as hack in it to work around the fact that normalize_param_env_or_error is broken. When relating two constants we attempt to evaluate them (aka normalize them). This is not an issue in any way specific to const generics, type aliases also have the same issue as demonstrated in this code.

Opening just for a crater run

r? @compiler-errors

[compiler-errors]

@bors try

[bors]

⌛ Trying commit 8fbccd1f5dda000ceda7aca10e645f64bb1e5adc with merge b7d03861bf345e4ad2ddeaeb856c296223a4d00f...

[bors]

☀️ Try build successful - checks-actions
Build commit: b7d03861bf345e4ad2ddeaeb856c296223a4d00f (b7d03861bf345e4ad2ddeaeb856c296223a4d00f)

[compiler-errors]

@craterbot check

@rust-timer build b7d03861bf345e4ad2ddeaeb856c296223a4d00f

[craterbot]

👌 Experiment pr-111622 created and queued.
🤖 Automatically detected try build b7d03861bf345e4ad2ddeaeb856c296223a4d00f
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🚧 Experiment pr-111622 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[rust-timer]

Finished benchmarking commit (b7d03861bf345e4ad2ddeaeb856c296223a4d00f): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.7%	[1.7%, 1.7%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.5%	[-1.5%, -1.5%]	6
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 644.092s -> 642.909s (-0.18%)

[craterbot]

🎉 Experiment pr-111622 is completed!
📊 6 regressed and 5 fixed (275257 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[BoxyUwU]

I think I would not like to land this all the regressions seem to be things that ought to work anyway and the motivation for this change is not that big since #111623 is also viable. Good to have the crater results though